gh-141984: Reword and reorganize Subscription (and Slicing) docs#141985
gh-141984: Reword and reorganize Subscription (and Slicing) docs#141985encukou merged 23 commits intopython:mainfrom
Conversation
Co-authored-by: Blaise Pabon <blaise@gmail.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Blaise Pabon <blaise@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
encukou
left a comment
encukou
left a comment
There was a problem hiding this comment.
Thank you for going through this!
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Just a few little things, overall looks very good!
Doc/reference/expressions.rst
Outdated
| subscription: `primary` '[' `subscript` ']' | ||
| subscript: `slice` | `tuple_slices` | ||
| tuple_slices: ','.(`slice` | `starred_expression`)+ [','] | ||
| slice: `proper_slice` | `assignment_expression` |
There was a problem hiding this comment.
By this grammar, if one does something[0], 0 is an int and is a slice, but that contradicts with your glossary entry, that states it must be a "an object of type slice"?
There was a problem hiding this comment.
That's a good point. I've considered the terms and the rules separate namespaces, but i agree it can be confusing.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
I read through most during your unicode shenanigans ;-), a few small things but otherwise LGTM.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
pythonGH-141985) (cherry picked from commit e423e0c) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-144476 is a backport of this pull request to the 3.14 branch. |
pythonGH-141985) Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
3 participants
This merges the Subscriptions and Slicings sections in the language reference. From the parser's point of view, slicing is a special case of subscription, and it makes sense to document it that way too.
The PR also touches Data model documentation: I've tried to move details of the runtime behaviour there, and to de-duplicate (and cross-link) as needed.
Similar for the
sliceattribute docs.Todo:
📚 Documentation preview 📚: https://cpython-previews--141985.org.readthedocs.build/